feat: Suggesting best routes #40
Conversation
…charya/prep-project-22.JUL.PREP.2 into best_routes_possible
…charya/prep-project-22.JUL.PREP.2 into best_routes_possible
…PREP.2 into MLH-new-branch
✅ Deploy Preview for prep-22-jul-prep-2-project ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| import "leaflet-routing-machine"; | ||
|
|
||
| function createRoutineMachineLayer({geocodes}) { | ||
| console.log(geocodes); |
There was a problem hiding this comment.
remove console.log if you are done with testing
| @@ -0,0 +1,23 @@ | |||
| import leaflet from "leaflet"; | |||
There was a problem hiding this comment.
This entire component could be shifted to /Components since it does not return a webpage/JSX.
| fetch(`https://geocode.search.hereapi.com/v1/geocode?q=${toCity}&apiKey=${process.env.REACT_APP_HEREAPI}`) | ||
| .then((res) => res.json()) | ||
| .then((result) => { | ||
| //console.log(result); |
There was a problem hiding this comment.
remove this comment, also remove it from line 28
There was a problem hiding this comment.
There are two console logs on lines 15 and 39 of /Search.js. I know you have not made those changes. But if possible please remove those as well.
| @@ -1,18 +1,91 @@ | |||
| import React from "react"; | |||
| import React, {useState} from "react"; | |||
There was a problem hiding this comment.
you can import useEffect here so you don't have to write React.useEffect() everytime.
Also, React is already imported at the global scope for all /src files for React v16+ (I could be technically wrong here, what I mean is you don' need to import React explicitly in /src/ files.
|
|
||
|
|
||
| window.navigator.geolocation.getCurrentPosition((position) => { | ||
| fetch(`https://api.openweathermap.org/data/2.5/weather?lat=${position.coords.latitude}&lon=${position.coords.longitude}&appid=${process.env.REACT_APP_APIKEY}`) |
There was a problem hiding this comment.
Similar code exists in /screen/home.js. You can receive coordinates and city as props and save this API call.
CC: @Krishi-02
There was a problem hiding this comment.
FYI: you are using lon to denote longitude whereas the rest of the app is using lng.
If you can replace your lon with lng, that would be great. Otherwise, don't forget to change the name of that key.
| @@ -21,6 +21,7 @@ | |||
| npm-debug.log* | |||
| yarn-debug.log* | |||
| yarn-error.log* | |||
| yarn.lock | |||
There was a problem hiding this comment.
@sumana2001, should we keep this file in gitignore or not?
|
Clicking on the find route button is causing an error. This is clearly because you used something related to One thing you can try is implementing
|
Closes #17
